Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing bug in labeler #15406

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fixing bug in labeler #15406

merged 1 commit into from
Nov 25, 2024

Conversation

patrickhuie19
Copy link
Contributor

https://github.com/smartcontractkit/chainlink/blame/develop/core/services/workflows/engine.go#L1261 uses a hex encoded version of the workflow name string instead of the workflow name string itself.

@patrickhuie19 patrickhuie19 requested a review from a team as a code owner November 25, 2024 17:05
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

patrickhuie19
patrickhuie19 commented Nov 25, 2024
View reviewed changes
core/services/workflows/engine.go
@@ -1263,7 +1263,7 @@ func NewEngine(ctx context.Context, cfg Config) (engine *Engine, err error) {
engine = &Engine{
Copy link
Contributor Author

@patrickhuie19 patrickhuie19 Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note @cedric-cordenier @justinkaseman that this hex encoded value from workflow.name = hex.EncodeToString([]byte(cfg.WorkflowName)) is passed into the engine, which has downstream consumers like

chainlink/core/services/workflows/engine.go

Line 442 in 7dcc1fd

WorkflowName: e.workflow.name,

Do capabilities expect a hex encoded string for workflow name? (maybe you expected long workflow names?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, consumers expect hex encoded strings.

bolekk
bolekk approved these changes Nov 25, 2024
View reviewed changes
core/services/workflows/engine.go
@@ -1263,7 +1263,7 @@ func NewEngine(ctx context.Context, cfg Config) (engine *Engine, err error) {
engine = &Engine{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, consumers expect hex encoded strings.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

@patrickhuie19 patrickhuie19 added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 73788c6 Nov 25, 2024
146 of 147 checks passed
@patrickhuie19 patrickhuie19 deleted the bug/metric-labeler-workflow-name branch November 25, 2024 18:01
bolekk pushed a commit that referenced this pull request Dec 11, 2024
@patrickhuie19 @bolekk
fixing bug in labeler (#15406)
79d0047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@bolekk bolekk bolekk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhuie19 @bolekk @vyzaldysanchez